Allow function address ambiguities on initial pass

src/smgdc/vtable.py

@@ -94,7 +94,7 @@ def get_vtables_from_address(bin: "LinuxBinary", vt: Symbol) -> list[VTable]:
     # returns a list of vtables for each vtable present on the class
     class VTableFunction(typing.NamedTuple):
         tblidx: int
-        sym: Symbol
+        possible_syms: set[Symbol]
 
     table_index = 0
     function_list: list[VTableFunction] = []
@@ -111,8 +111,8 @@ def get_vtables_from_address(bin: "LinuxBinary", vt: Symbol) -> list[VTable]:
             next(vtable_range)
             continue
 
-        if len(fnsyms) == 1 or not function_list:
-            function_list.append(VTableFunction(table_index, fnsyms.pop()))
+        if len(fnsyms) == 1:
+            function_list.append(VTableFunction(table_index, fnsyms))
             continue
         elif len(fnsyms) > 1:
             # function in vtable is referenced by multiple names; perform disambiguation
@@ -126,14 +126,26 @@ def get_vtables_from_address(bin: "LinuxBinary", vt: Symbol) -> list[VTable]:
             # without doing multiple passes and saving the disambiguity somewhere it'll be difficult to match
 
             if matched_overload:
-                function_list.append(VTableFunction(table_index, matched_overload))
+                function_list.append(VTableFunction(table_index, {matched_overload}))
                 continue
-        # TODO: we need to resolve a symbol here; otherwise we can't correctly handle this
+
+        function_list.append(VTableFunction(table_index, fnsyms))
+
+    for n, vfn in enumerate(function_list):
+        if n == 0:
+            # HACK: skip duplicated references to destructor
+            # we should be doing this at the disambiguation stage
+            continue
+        elif len(vfn.possible_syms) == 1:
+            continue
+
+        # we should never receive an empty ``VTableFunction.possible_syms``
+        # for now we need to assert that a function address is unambiguous given the context
         vt_name = demangler.parse(vt.name)
-        candidate_names = set(sym.name for sym in fnsyms)
+        candidate_names = set(sym.name for sym in vfn.possible_syms)
         raise Exception(f"Ambiguity in {vt_name} position {n}; candidates {candidate_names}")
 
     return [
-        list(vfn.sym for vfn in vtbl)
+        list(vfn.possible_syms.pop() for vfn in vtbl)
         for tblidx, vtbl in itertools.groupby(function_list, key=operator.attrgetter("tblidx"))
     ]